Warnings on array parameter and headers already sent by

[acyba]

Hello,

I think there is an issue when you have a 2 levels array parameter in your URL.
For example an URL like [url]http://www.mydomain.com?param[lvl1][lvl2]=value[/url]

There are the following warnings when trying to translate the page:
Warning: urlencode() expects parameter 1 to be string, array given in /srv/www/vhosts/www.domain.com/www/gtranslate/gtranslate.php on line 25

Warning: Cannot modify header information - headers already sent by (output started at /srv/www/vhosts/www.domain.com/www/gtranslate/gtranslate.php:25) in /srv/www/vhosts/www.domain.com/www/gtranslate/gtranslate.php on line 141

How can we solve this?

Best regards

[Edvard]

Hi,

Can you provide a link to live example?

Thanks!

[acyba]

Hello,

Sure, here is a link: [url]https://www.acyba.com/fr/?param[lvl1][lvl2]=value[/url]
You will have the same issue on any page of the site if you add this kind of parameter in the URL.
Best regards

[Edvard]

Hi,

Try to replace

Code: Select all

$get_params = array();
foreach($_GET as $key => $val) {
    if($key != 'glang' and $key != 'gurl') {
        if(is_array($val))
            foreach($val as $v)
                $get_params[] = $key.'[]='.urlencode($v);
        else
            $get_params[] = $key.'='.urlencode($val);
    }
}

if(count($get_params)) {
    $page_url .= '?' . implode('&', $get_params);
}


with

Code: Select all

$get_params = $_GET;
if(isset($get_params['glang']))
   unset($get_params['glang']);
if(isset($get_params['gurl']))
    unset($get_params['gurl']);

if(count($get_params)) {
   $page_url .= '?' . http_build_query($get_params);
}


in gtranslate/gtranslate.php file.

[acyba]

Hello,

Thanks a lot for this code. This is now working.
Best regards

[Edvard]

You are welcome. Good to hear that.